Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-menu): menu action focus on mobile #2103

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

dauriamarco
Copy link
Contributor

Sets the focus on the first focusable inside the menu on open (mobile).

@dauriamarco dauriamarco self-assigned this Oct 23, 2023
@github-actions github-actions bot temporarily deployed to preview-pr2103 October 23, 2023 13:22 Inactive
@dauriamarco dauriamarco force-pushed the fix/sbb-menu-action-focus branch from 14029f8 to 855cc4b Compare October 23, 2023 15:06
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot temporarily deployed to preview-pr2103 October 23, 2023 15:21 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #2103 (855cc4b) into master (ab917b0) will decrease coverage by 18.50%.
Report is 1789 commits behind head on master.
The diff coverage is 30.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           master    #2103       +/-   ##
===========================================
- Coverage   54.85%   36.35%   -18.50%     
===========================================
  Files          49      288      +239     
  Lines        1659    11004     +9345     
  Branches      406     2412     +2006     
===========================================
+ Hits          910     4001     +3091     
- Misses        671     6735     +6064     
- Partials       78      268      +190     
Files Coverage Δ
...c/components/sbb-action-group/sbb-action-group.tsx 100.00% <100.00%> (ø)
...mponents/sbb-alert-group/sbb-alert-group.events.ts 100.00% <100.00%> (ø)
src/components/sbb-alert/sbb-alert.events.ts 100.00% <100.00%> (ø)
...onents/sbb-autocomplete/sbb-autocomplete.events.ts 100.00% <ø> (ø)
src/components/sbb-card-badge/sbb-card-badge.tsx 100.00% <100.00%> (+11.11%) ⬆️
src/components/sbb-card/sbb-card.stories.tsx 0.00% <ø> (ø)
src/components/sbb-card/sbb-card.tsx 90.00% <ø> (ø)
.../sbb-checkbox-group/sbb-checkbox-group.stories.tsx 0.00% <ø> (ø)
...mponents/sbb-checkbox-group/sbb-checkbox-group.tsx 33.33% <ø> (ø)
src/components/sbb-checkbox/sbb-checkbox.events.ts 0.00% <ø> (ø)
... and 55 more

... and 239 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dauriamarco dauriamarco merged commit 9827fa1 into master Oct 23, 2023
@dauriamarco dauriamarco deleted the fix/sbb-menu-action-focus branch October 23, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants