Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-navigation, sbb-menu, sbb-dialog): screen readers readability #2092

Merged
merged 18 commits into from
Oct 19, 2023

Conversation

dauriamarco
Copy link
Contributor

@dauriamarco dauriamarco self-assigned this Oct 18, 2023
@github-actions github-actions bot temporarily deployed to preview-pr2092 October 18, 2023 12:00 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #2092 (bfba1cd) into master (ab917b0) will decrease coverage by 18.40%.
Report is 1778 commits behind head on master.
The diff coverage is 30.54%.

❗ Current head bfba1cd differs from pull request most recent head 2403ad9. Consider uploading reports for the commit 2403ad9 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           master    #2092       +/-   ##
===========================================
- Coverage   54.85%   36.45%   -18.40%     
===========================================
  Files          49      288      +239     
  Lines        1659    10918     +9259     
  Branches      406     2379     +1973     
===========================================
+ Hits          910     3980     +3070     
- Misses        671     6674     +6003     
- Partials       78      264      +186     
Files Coverage Δ
...c/components/sbb-action-group/sbb-action-group.tsx 100.00% <100.00%> (ø)
...mponents/sbb-alert-group/sbb-alert-group.events.ts 100.00% <100.00%> (ø)
src/components/sbb-alert/sbb-alert.events.ts 100.00% <100.00%> (ø)
...onents/sbb-autocomplete/sbb-autocomplete.events.ts 100.00% <ø> (ø)
src/components/sbb-card-badge/sbb-card-badge.tsx 100.00% <100.00%> (+11.11%) ⬆️
src/components/sbb-card/sbb-card.stories.tsx 0.00% <ø> (ø)
src/components/sbb-card/sbb-card.tsx 90.00% <ø> (ø)
.../sbb-checkbox-group/sbb-checkbox-group.stories.tsx 0.00% <ø> (ø)
...mponents/sbb-checkbox-group/sbb-checkbox-group.tsx 33.33% <ø> (ø)
src/components/sbb-checkbox/sbb-checkbox.events.ts 0.00% <ø> (ø)
... and 55 more

... and 239 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dauriamarco dauriamarco changed the title fix(sbb-navigation): screen readers readability fix(sbb-navigation, sbb-menu, sbb-dialog): screen readers readability Oct 18, 2023
@github-actions github-actions bot temporarily deployed to preview-pr2092 October 18, 2023 12:30 Inactive
@jeripeierSBB jeripeierSBB force-pushed the fix/sbb-navigation-visibility branch from 8853ca6 to bfba1cd Compare October 18, 2023 14:39
@github-actions github-actions bot temporarily deployed to preview-pr2092 October 18, 2023 15:00 Inactive
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Nice work!

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, finally!

@jeripeierSBB jeripeierSBB merged commit dbddfa8 into master Oct 19, 2023
@jeripeierSBB jeripeierSBB deleted the fix/sbb-navigation-visibility branch October 19, 2023 13:31
jeripeierSBB added a commit that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants