-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sbb-navigation, sbb-menu, sbb-dialog): screen readers readability #2092
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #2092 +/- ##
===========================================
- Coverage 54.85% 36.45% -18.40%
===========================================
Files 49 288 +239
Lines 1659 10918 +9259
Branches 406 2379 +1973
===========================================
+ Hits 910 3980 +3070
- Misses 671 6674 +6003
- Partials 78 264 +186
... and 239 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8853ca6
to
bfba1cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, finally!
Solves https://flow.sbb.ch/browse/SBBCH-17317