refactor(sbb-option, sbb-optgroup, sbb-autocomplete, sbb-select): lit migration #2062
Conversation
TomMenga
force-pushed
the
migr/sbb-autocomplete
branch
2 times, most recently
from
582e048 to
4e99d50
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## lit-migration #2062 +/- ##
================================================
Coverage ? 92.07%
================================================
Files ? 161
Lines ? 22655
Branches ? 1132
================================================
Hits ? 20860
Misses ? 1782
Partials ? 13 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| <sbb-form-field> | ||
| <input /> | ||
| <sbb-autocomplete id="myAutocomplete"> | ||
| <sbb-autocomplete id="myAutocomplete" style="--sbb-options-panel-animation-duration: 0.01s"> |
There was a problem hiding this comment.
what about using disableAnimation property? this would be the public API of the autocomplete
There was a problem hiding this comment.
That was the first choice but, for reasons I haven't been able to explain, if I do that the animationend event is not fired. After half a day of debugging, I surrendered and used that workaround.
I accepted the compromise since the true meaning of that is just to speed up tests to avoid the timeout (since they have a lot of close/open interactions)
TomMenga
force-pushed
the
migr/sbb-autocomplete
branch
from
4e99d50 to
3675c60
Compare
src/components/sbb-timetable-row-header/sbb-timetable-row-header.spec.ts
Show resolved
Hide resolved
TomMenga
force-pushed
the
migr/sbb-autocomplete
branch
from
81ae599 to
e222081
Compare
No description provided.