Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: tab-content pseudo-elements create scrollbar inside map-container #2835

Closed
3 tasks done
xXNickznXx opened this issue Jun 26, 2024 · 1 comment · Fixed by #2921 or #2907
Closed
3 tasks done

[Bug]: tab-content pseudo-elements create scrollbar inside map-container #2835

xXNickznXx opened this issue Jun 26, 2024 · 1 comment · Fixed by #2921 or #2907
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@xXNickznXx
Copy link

Preflight Checklist

Bug type

Functionality

It affects the following packages

Components

Which version of Lyne Components are you using

1.0.0

Operating system

No response

Browser / Browser version

No response

Input mode

None

Additional settings

No response

What happened?

Found a bug on a mobile-sized screen when combining map-container with tab-group. An unnecessary scrollbar ist shown.
Reproduction: https://stackblitz.com/edit/tab-content-after-creates-scrollbar-inside-map-container?file=src%2Fmain.html

After some testing it seems to be a combination of 2 issues related to this mixin: src/elements/tabs/tab-group/tab-group.scss#L21

One is that the ::after pseudo-element still occupies space underneath the tab-content.
This could be solved by adding overflow: hidden to the mixin

The second is that the height which is set here: src/elements/tabs/tab-group/tab-group.ts#L247 is too small because the margin-top of the paragraph inside isnt included.
This can also be seen in the storybook by changing to "Tab title four" the scrollbar appears.
This could be solved by moving the mixin from the tab-group to the tab itself.

Steps to reproduce the issue

Relevant log output

No response

@xXNickznXx xXNickznXx added the type: bug 🐛 Something isn't working label Jun 26, 2024
@xXNickznXx xXNickznXx changed the title [Bug]: [Bug]: tab-content pseudo-elements create scrollbar inside map-container Jun 26, 2024
@jeripeierSBB jeripeierSBB moved this from Funnel to Next in ESTA Web Lyne Design System Jul 4, 2024
@jeripeierSBB jeripeierSBB self-assigned this Jul 9, 2024
@jeripeierSBB jeripeierSBB moved this from Next to In progress in ESTA Web Lyne Design System Jul 9, 2024
@jeripeierSBB
Copy link
Contributor

Thanks for the hints to solve the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Archived in project
2 participants