Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

story(sbb-card): initial implementation #1216

Closed
10 tasks
OkanBostan opened this issue Jun 8, 2022 · 3 comments · Fixed by #1358
Closed
10 tasks

story(sbb-card): initial implementation #1216

OkanBostan opened this issue Jun 8, 2022 · 3 comments · Fixed by #1358
Assignees
Labels
proposal: accepted team: ESTA Web Will be done by team ESTA Web

Comments

@OkanBostan
Copy link

OkanBostan commented Jun 8, 2022

Feature Description

We want to implement the card design.

Figma Spec

Design Spec

  • No special considerations

Technical Spec

  • Content should be provided via unnamed slot
  • Provide <slot name="badge"> for a <sbb-card-badge>
    • Hide/Remove the slot for sizes below m
  • Provide property size with the appropriate sizes. Default to m.
  • The card is an interactive element and should implement the LinkButtonProperties interface

Definition of Done

  • Component is implemented
  • Documentation is added
  • Tests are implemented
  • E2E Tests are implemented
  • Storybook stories are implemented
  • Navigation via keyboard is tested
  • Screen reader output is tested
  • High-contrast is tested
  • Remaining accessibility is tested
  • UX approved
@kyubisation kyubisation changed the title lyne-card story(sbb-card): initial implementation Jul 8, 2022
@kyubisation kyubisation removed their assignment Jul 14, 2022
@osminaz
Copy link
Contributor

osminaz commented Jul 18, 2022

Top-padding of the card should change, whenever there is a sbb-card-badge. Should this be in the scope of this issue?

@sebastiencloss
Copy link
Contributor

Will be made by Team-Lynx.

@sebastiencloss sebastiencloss self-assigned this Jul 18, 2022
@sebastiencloss
Copy link
Contributor

We won't need it for now:

Minaz Osman
Hey General, do somebody know, why we need the sbb-card component? Intuitively I would keep the sbb-card as a mixin and handle the sizes and the card-badge in the component where it is needed. (From my point of view, the card-badge will only be used for the timetable-row)

Spirig Lukas
We certainly want to implement/provide a generic sbb-card. If there is no need from sbb.ch side, we will however reduce priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal: accepted team: ESTA Web Will be done by team ESTA Web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants