refactor: remove obsolete getLocalName() (#3110)

sbb-design-systems · Sep 23, 2024 · f349463 · f349463
1 parent 333e90e
commit f349463
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 12 deletions.
diff --git a/src/elements/core/base-elements/action-base-element.ts b/src/elements/core/base-elements/action-base-element.ts
@@ -1,7 +1,6 @@
 import { html, LitElement, type TemplateResult } from 'lit';
 
 import { hostAttributes } from '../decorators.js';
-import { getLocalName } from '../dom.js';
 
 /**
  * Whenever an element can be disabled it has disabled property
@@ -64,10 +63,6 @@ export abstract class SbbActionBaseElement extends LitElement {
 
   /** Default render method for button-like components. */
   protected override render(): TemplateResult {
-    return html`
-      <span class="sbb-action-base ${this.localName ?? getLocalName(this)}">
-        ${this.renderTemplate()}
-      </span>
-    `;
+    return html` <span class="sbb-action-base ${this.localName}">${this.renderTemplate()}</span> `;
   }
 }
diff --git a/src/elements/core/base-elements/link-base-element.ts b/src/elements/core/base-elements/link-base-element.ts
@@ -3,7 +3,6 @@ import { property } from 'lit/decorators.js';
 
 import { SbbLanguageController } from '../controllers.js';
 import { hostAttributes } from '../decorators.js';
-import { getLocalName } from '../dom.js';
 import { i18nTargetOpensInNewWindow } from '../i18n.js';
 
 import { SbbActionBaseElement } from './action-base-element.js';
@@ -65,7 +64,7 @@ export abstract class SbbLinkBaseElement extends SbbActionBaseElement {
   protected override render(): TemplateResult {
     return html`
       <a
-        class="sbb-action-base ${this.localName ?? getLocalName(this)}"
+        class="sbb-action-base ${this.localName}"
         href=${this.href || nothing}
         ?download=${this.download}
         target=${this.target || nothing}

diff --git a/src/elements/core/dom/ssr.ts b/src/elements/core/dom/ssr.ts
@@ -9,6 +9,8 @@ const localNameCache = new Map<unknown, string>();
  * https://github.com/lit/lit/blob/main/packages/labs/ssr-dom-shim/src.ts (See CustomElementRegistryShim)
  *
  * Can be removed once https://github.com/lit/lit/pull/4553 is merged/released.
+ *
+ * @deprecated Will be removed with next major version
  */
 export function getLocalName(element: LitElement): string {
   if (localNameCache.has(element.constructor)) {

diff --git a/src/elements/core/mixins/named-slot-list-mixin.ts b/src/elements/core/mixins/named-slot-list-mixin.ts
@@ -1,8 +1,6 @@
 import { html, type LitElement, nothing, type TemplateResult } from 'lit';
 import { state } from 'lit/decorators.js';
 
-import { getLocalName } from '../dom.js';
-
 import type { AbstractConstructor } from './constructor.js';
 import { SbbHydrationMixin, type SbbHydrationMixinType } from './hydration-mixin.js';
 
@@ -130,7 +128,7 @@ export const SbbNamedSlotListMixin = <
       if (listSlotNames.length >= 2) {
         return html`
           <ul
-            class=${attributes.class || (this.localName ?? getLocalName(this))}
+            class=${attributes.class || this.localName}
             aria-label=${attributes.ariaLabel || nothing}
             aria-labelledby=${attributes.ariaLabelledby || nothing}
           >
@@ -146,7 +144,7 @@ export const SbbNamedSlotListMixin = <
         `;
       } else if (listSlotNames.length === 1) {
         return html`<sbb-screen-reader-only>${attributes.ariaLabel}</sbb-screen-reader-only>
-          <span class=${attributes.class || (this.localName ?? getLocalName(this))}>
+          <span class=${attributes.class || this.localName}>
             <span><slot name=${listSlotNames[0].name}></slot></span>
           </span>
           ${this.renderHiddenSlot()} `;