Skip to content

Commit

Permalink
fix: review
Browse files Browse the repository at this point in the history
  • Loading branch information
dauriamarco committed Dec 12, 2023
1 parent e28d94a commit 98f2d52
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/components/dialog/dialog.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ describe('sbb-dialog', () => {
});

describe('sbb-dialog with long content', () => {
let element: SbbDialog;
let element: SbbDialogElement;

beforeEach(async () => {
await setViewport({ width: 900, height: 300 });
Expand All @@ -444,7 +444,7 @@ describe('sbb-dialog with long content', () => {
});

it('renders', () => {
assert.instanceOf(element, SbbDialog);
assert.instanceOf(element, SbbDialogElement);
});

it('sets the data-overflows attribute', async () => {
Expand Down
4 changes: 2 additions & 2 deletions src/components/dialog/dialog.scss
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,9 @@
}

// In order to improve the header transition on mobile (especially iOS) we use
// a combination of the transform and margin properties on the smaller breakpoints,
// a combination of the transform and margin properties on touch devices,
// while on desktop we use just the margin-block for a better transition of the visible scrollbar.
@include sbb.mq($from: medium) {
@include sbb.hover-mq($hover: true) {
transform: unset;
margin-block: var(--sbb-dialog-header-margin-block-start) 0;
transition: margin var(--sbb-dialog-animation-duration) var(--sbb-dialog-animation-easing);
Expand Down
1 change: 0 additions & 1 deletion src/components/dialog/dialog.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ const textBlockStyle: Args = {
backgroundColor: 'var(--sbb-color-milk-default)',
border: 'var(--sbb-border-width-1x) solid var(--sbb-color-cloud-default)',
borderRadius: 'var(--sbb-border-radius-4x)',
zIndex: '100',
};

const textBlock = (): TemplateResult => html`
Expand Down

0 comments on commit 98f2d52

Please sign in to comment.