Skip to content

Commit

Permalink
fix: use renderAttributesOnCreate for react (#2323)
Browse files Browse the repository at this point in the history
  • Loading branch information
jeripeierSBB authored Jan 9, 2024
1 parent a5df58f commit 1de1379
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/react/core/create-component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ export const createComponent = <I extends HTMLElement, E extends EventNames = {}
elementClass,
events,
displayName,
renderAttributesOnCreate,
}: Options<I, E>): ReactWebComponent<I, E> => {
const eventProps = new Set(Object.keys(events ?? {}));

Expand Down Expand Up @@ -266,10 +265,6 @@ export const createComponent = <I extends HTMLElement, E extends EventNames = {}
if (eventProps.has(k) || k in elementClass.prototype) {
elementProps[k] = v;

if (!renderAttributesOnCreate) {
continue;
}

const elementProperty = elementProperties?.get(k);
const toAttribute = (elementProperty?.converter as ComplexAttributeConverter)?.toAttribute;
if (
Expand Down

0 comments on commit 1de1379

Please sign in to comment.