Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/granularity handling fix #10

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

elineii
Copy link
Collaborator

@elineii elineii commented Feb 12, 2024

#1

  • Fixed a bug with incorrect determination of common types of frequency of timestamps in time series.
  • Improved automatic granularity expansion.
  • Added possibility to add custom granularity settings (new part in tutorial).

If the rows do not contain segments that are too short (that are shorter than history + horizon), then tsururu will try to extract the row granularity on its own. Сurrently the following types are supported:

  • Yearly (and YearlyEnd)
  • Quarterly (and Quarterly)
  • Monthly (and MonthlyEnd)
  • Weekly
  • Daily
  • Hourly
  • Minlutely
  • Secondly
  • Microsecondly

There is also support for compound granularities (10 days, 15 minutes, 32 seconds, etc.).

It is possible to set your own granularity using the pd.DateOffset class or related classes from pandas.tseries.offsets, which must be fed as delta parameter into the Dataset class.

#5

Fixed a bug with piplane crash if features have specific characters in their names (e.g. brackets) and if features have nested names (e.g. feature, feature0, feature1, etc.).

Fixed bug with drop_raw_feature=True, now this parameter works as intuitively expected

Fixed a bug with predictions changing when the order of transformer application passing is changed (more specifically, features are now fed to the ML model in lexicographical order).

Fixed situation with need to sort dataset by id and date before initialization of TSDataset.

@elineii elineii added the bug Something isn't working label Feb 12, 2024
@elineii elineii self-assigned this Feb 12, 2024
@elineii elineii linked an issue Feb 12, 2024 that may be closed by this pull request
@elineii elineii linked an issue Feb 19, 2024 that may be closed by this pull request
Copy link
Collaborator

@DESimakov DESimakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge with TODO refactor feature pipeline with new logic

@DESimakov DESimakov merged commit 39c32d6 into development Feb 21, 2024
@elineii elineii deleted the bugfix/granularity_handling_fix branch March 1, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with long feature names Bug with annual data?
2 participants