Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python_arch input option #6

Merged
merged 1 commit into from
Apr 9, 2023
Merged

Add python_arch input option #6

merged 1 commit into from
Apr 9, 2023

Conversation

Young-Lord
Copy link
Contributor

No description provided.

@sayyid5416
Copy link
Owner

It seems like arch was not used in pyinstaller command.

@Young-Lord
Copy link
Contributor Author

Young-Lord commented Apr 6, 2023 via email

@sayyid5416
Copy link
Owner

@Young-Lord Have you tested this change properly?

@Young-Lord
Copy link
Contributor Author

Yes. I have confirmed this works properly.
Example: https://github.com/Young-Lord/QQ-History-Backup/actions/runs/4645432036
successfully build a x86 exe, with requirements requests and tkinter

example

@sayyid5416
Copy link
Owner

Thanks for confirming. I'll do a few tests and then merge it.

@sayyid5416 sayyid5416 merged commit 0c5a7b8 into sayyid5416:main Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayyid5416 sayyid5416 sayyid5416 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Young-Lord @sayyid5416