Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions for Node JS 20 #18

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

aliencaocao
Copy link
Contributor

Closes #17

@sayyid5416
Copy link
Owner

sayyid5416 commented Mar 11, 2024

I've not read the changes in all those actions whose version you have increased.

  1. Are there any breaking changes?
  2. How much you tested these changes?

@aliencaocao
Copy link
Contributor Author

Tried it on my own project with custom requirements, custom python version and custom args
https://github.com/aliencaocao/ytdlp-gui/actions/runs/8229615076

@sayyid5416
Copy link
Owner

OK. I'll take a look and merge soon. Thanks for the PR btw

@sayyid5416 sayyid5416 self-assigned this Mar 11, 2024
@sayyid5416 sayyid5416 merged commit eb00feb into sayyid5416:main Mar 11, 2024
@aliencaocao aliencaocao deleted the bump-versions branch March 11, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js 16 actions are deprecated for some dependency actions
2 participants