Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean_checkout input to handle cleaning after checkout #14

Merged
merged 6 commits into from
Jan 28, 2024

Conversation

aliencaocao
Copy link
Contributor

@aliencaocao aliencaocao commented Jan 21, 2024

clean_checkout input

  • default: true
  • If true, perform a clean checkout; if false, skip cleaning. Cleaning will remove all existing local files not in the repository during checkout. If you use utilities like pyinstaller-versionfile, set this to false.

This fixes issue of user wanting to use their own version text file but it is being cleaned by the checkout and very hard to debug.
See aliencaocao/netease_cloudmusic_discord_rpc#4

@sayyid5416
Copy link
Owner

@aliencaocao Add this feature as optional. Add an input which controls if clean will be True or False

@sayyid5416 sayyid5416 added the Incomplete This is not yet completed, either it lacks something or needs refinement. label Jan 25, 2024
@aliencaocao
Copy link
Contributor Author

@sayyid5416 is this ok?

@sayyid5416
Copy link
Owner

add in readme and other places as well, wherever necessary. I'll check later. Thanks for contribution btw.

@aliencaocao
Copy link
Contributor Author

im not sure where else is needed except for readme. just updated it

@sayyid5416 sayyid5416 removed the Incomplete This is not yet completed, either it lacks something or needs refinement. label Jan 28, 2024
@sayyid5416
Copy link
Owner

By default, clean should be true as it's true by default in actions/checkout

@sayyid5416 sayyid5416 self-assigned this Jan 28, 2024
@aliencaocao
Copy link
Contributor Author

done

README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@sayyid5416
Copy link
Owner

Do you need to add anything else to this PR?

@aliencaocao
Copy link
Contributor Author

Nope

@sayyid5416 sayyid5416 changed the title Disable automatic cleaning after checkout clean_checkout input to handle cleaning after checkout Jan 28, 2024
@sayyid5416 sayyid5416 merged commit 8085bb0 into sayyid5416:main Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants