Es6 #184
Merged
Es6 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node <= 0.xx doesn't support es6 syntax ref: http://node.green/
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
=========================================
Coverage ? 69.46%
=========================================
Files ? 2
Lines ? 131
Branches ? 29
=========================================
Hits ? 91
Misses ? 40
Partials ? 0
Continue to review full report at Codecov.
|
In order to use es6 in the package we need a module bundler (webpack2) that transpile our code using babel. To do that we did: - added bumped to manage releases - updated travis test - updated package.json and bower.json in order to work with webpack2 - added a CHANGELOG page - updated index.html - added many fix on module - added eslint and remove jsonhint - removed bower dependency - updated documentation - added automatic gh-pages deploy - added angularjs and pdfjs as peerDependencies aside note of duplicated dependencies in package.json: angularjs and pdfjs are in both list because we need to alert user if they lack AND for developing/testig purposes ref: #90
Generate code coverage using Istanbul
This was referenced Apr 18, 2017
Closed
|
FYI @boyanin @rhyskoedijk |
|
release in a couple of minutes |
This was referenced Apr 18, 2017
Closed
|
@simobasso awesome! Thanks a lot! I have totally forgotten this. So many things on my shoulders right now, but will play with it as soon as possible :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving whole package to es6.
Ref. #163