-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudSqlMySql Test Scenarios #1
CloudSqlMySql Test Scenarios #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsmekumari Changes requested.
e2e-test/src/test/java/io/cdap/plugin/cloudsqlmysql/stepsdesign/CloudSqlMySql.java
Show resolved
Hide resolved
List<String> propertiesSchemaColumnList = new ArrayList<>(); | ||
Map<String, String> sourcePropertiesOutputSchema = new HashMap<>(); | ||
static int i = 0; | ||
GcpClient gcpClient = new GcpClient(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this initialisation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
@Then("Get Count of no of records transferred to BigQuery in {string}") | ||
public void getCountOfNoOfRecordsTransferredToBigQueryIn(String table) throws IOException, InterruptedException { | ||
int countRecords; | ||
countRecords = gcpClient.countBqQuery(E2ETestUtils.pluginProp(table)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gcpClient -> GcpClient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@Then("Validate count of records transferred from importQuery {string} to BigQuery in {string}") | ||
public void validateCountOfRecordsTransferredFromImportQueryToBigQueryIn(String importQuery, String bqTable) throws | ||
IOException, InterruptedException { | ||
int bqRecordsCount = GcpClient.countBqQuery(E2ETestUtils.pluginProp(bqTable)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gcpClient -> GcpClient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
folderName = E2ETestUtils.listObjects(E2ETestUtils.pluginProp(projectID), | ||
E2ETestUtils.pluginProp(bucketName)); | ||
Assert.assertTrue(folderName != null); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
*/ | ||
package io.cdap.plugin.cloudsqlmysql.locators; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
*/ | ||
package io.cdap.plugin.cloudsqlmysql.actions; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
* the License. | ||
*/ | ||
/** | ||
* Package contains the runner for the CloudSqlMySQL features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package contains step actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
* the License. | ||
*/ | ||
/** | ||
* Package contains the runner for the cloudSqlMySql features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contains locators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
@sawantpritam