Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudSqlMySql Test Scenarios #1

Merged

Conversation

itsmekumari
Copy link

@sawantpritam sawantpritam merged commit 012c0b6 into sawantpritam:e2e-cloudsqlmysql Dec 24, 2021
Copy link
Owner

@sawantpritam sawantpritam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsmekumari Changes requested.

List<String> propertiesSchemaColumnList = new ArrayList<>();
Map<String, String> sourcePropertiesOutputSchema = new HashMap<>();
static int i = 0;
GcpClient gcpClient = new GcpClient();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this initialisation

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@Then("Get Count of no of records transferred to BigQuery in {string}")
public void getCountOfNoOfRecordsTransferredToBigQueryIn(String table) throws IOException, InterruptedException {
int countRecords;
countRecords = gcpClient.countBqQuery(E2ETestUtils.pluginProp(table));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcpClient -> GcpClient

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Then("Validate count of records transferred from importQuery {string} to BigQuery in {string}")
public void validateCountOfRecordsTransferredFromImportQueryToBigQueryIn(String importQuery, String bqTable) throws
IOException, InterruptedException {
int bqRecordsCount = GcpClient.countBqQuery(E2ETestUtils.pluginProp(bqTable));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcpClient -> GcpClient

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

folderName = E2ETestUtils.listObjects(E2ETestUtils.pluginProp(projectID),
E2ETestUtils.pluginProp(bucketName));
Assert.assertTrue(folderName != null);

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra newline

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

*/
package io.cdap.plugin.cloudsqlmysql.locators;


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra newline

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

*/
package io.cdap.plugin.cloudsqlmysql.actions;


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra newline

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

* the License.
*/
/**
* Package contains the runner for the CloudSqlMySQL features.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package contains step actions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

* the License.
*/
/**
* Package contains the runner for the cloudSqlMySql features.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contains locators

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants