Fix namespace problem for array schema elements and respect XML schem… #802
Conversation
…a sequence ordering
…a sequence ordering (improved)
|
Looks like I need to add an additional test to avoid the decrease in coverage. |
|
Reverted bad patch for array handling. The patch for XML schema ordering works well for my use. |
|
This affects our integration. Ruby Hash default key order ends up determining the XML of the request instead of the governing WSDL document's |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue is now closed due to inactivity. If you believe this needs further action, please re-open to discuss. |
|
@warnickr thanks for your contribution, and apologies this went unreviewed so long. I think I understand this change. Would you be able to add some specs to cover this scenario? |
|
It may take me a few weeks to get to it, but I will merge in the latest and add some specs. |
|
Thank you for your persistence and your help. |
|
We've been bitten by this as well. I'm not that familiar with Gyoku etc. Is this PR still active? |
|
I'm not sure why this PR is not merged yet. Can we have some advances on this topic? I'm requiring this on a project. |
|
@warnickr do you need to share the burden? This seems like a vital update to a commonly used tool. |
|
This is still an issue for us. What do people think @pcai @olleolleolle? |
|
The current state is: the change needs specs. Any effort to add specs is welcome, even only a description in words (a PR to the PR would be even easier to use). |
|
This PR is still not eligible to merge because it doesn't have any accompanying tests, and it also has a merge conflict with main. I tried to update it and add a synthetic test, but I'm not very confident it has been tested correctly. I encountered several issues from testing and I believe they are addressed, but I don't have an example WSDL to test against. Can someone verify if this commit (based on main branch) addresses their issue?: 7351ccd Can someone provide a WSDL and example operation where this is an issue? This would help with testing |
…a sequence ordering