Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add binding for X509_digest #66

Merged
merged 4 commits into from
Feb 1, 2021
Merged

Conversation

schubev
Copy link
Contributor

@schubev schubev commented Jan 5, 2021

Adds bindings for the X509_digest function which retrieves a certificate’s fingerprint using one of a collection of digest algorithms.

Questions

  • SHA1, SHA256 and SHA384 satisfy my needs but it would be easy for me to add some more algorithms to the PR: do you think it is necessary? On the other hand it would still be easy to add some later on, on an as-needed basis.
  • It seems this repository has no tests. I personally use Alcotest and included the tests I used to build the feature in the PR, but I understand choosing a test framework may be out of scope for this PR so I can definitely just keep those in my fork.

@smimram smimram merged commit 5b3ffc1 into savonet:master Feb 1, 2021
@ArtichOwO ArtichOwO mentioned this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants