Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set proper cache dir for posix build #3977

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Set proper cache dir for posix build #3977

merged 5 commits into from
Jul 4, 2024

Conversation

toots
Copy link
Member

@toots toots commented Jun 20, 2024

This PR enhances caching support by separating system vs. user cache.

System cache is mostly for stdlib caching and should be shared by all users while user cache is for user scripts and should be user-specific.

Default locations:

  • windows: <executable directory>/cache for both
  • posix (system-wide install):
    • system: /var/cache/liquidsoap
    • user: $HOME/.cache/liquidsoap
  • dune:
    • system: set by dune
      • Local build: _build/install/default/share/liquidsoap-lang/cache
      • Installed: ~/.opam/<switch>/share/liquidsoap-lang/cache
    • user: $HOME/.cache/liquidsoap

Fixes: #3970

@toots
Copy link
Member Author

toots commented Jul 3, 2024

@vitoyucepi Description and PR updated. This should cover all bases now.

@vitoyucepi
Copy link
Collaborator

I didn't ask this question before, will the cache contain the hardcoded passwords?

password = "pass"
output.icecast(%mp3, blank(), password=password, mount="1")
output.icecast(%mp3, blank(), password="pass", mount="2")

@toots
Copy link
Member Author

toots commented Jul 4, 2024

I didn't ask this question before, will the cache contain the hardcoded passwords?

password = "pass"
output.icecast(%mp3, blank(), password=password, mount="1")
output.icecast(%mp3, blank(), password="pass", mount="2")

Excellent catch, thank you.

I just added proper permissions with customization env variables and documented them and also security concerns in the doc.

doc/content/language.md Outdated Show resolved Hide resolved
@toots
Copy link
Member Author

toots commented Jul 4, 2024

I think that this is good for merge. The docker build issues are related to debian-multimedia changing their DNS I believe.

@toots toots merged commit 33a62b4 into main Jul 4, 2024
24 of 26 checks passed
@toots toots deleted the cachedir branch July 4, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache path in packages
2 participants