refactor(prometheus): Change prometheus port #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I imagine that you're re-using an existing port because the list is limited? |
toots
approved these changes
Mar 13, 2024
|
Yeah, the list is full, there are no free ports. |
vitoyucepi
force-pushed
the
prometheus_port
branch
from
e514cf3
to
bb66eff
Compare
|
How about port 9669? |
|
I defer to you on that, I have no preference :-) |
|
I'm fine with the current number and waiting for the merge. |
vitoyucepi
force-pushed
the
prometheus_port
branch
2 times, most recently
from
3c52e6c
to
1ea6ff7
Compare
It's good practice to allocate a specific port for each individual Prometheus metrics exporter. This commit changes port 9090, which is used by the prometheus server itself, to 9599, which is used by an unavailable https://github.com/marco-m/pirograph exporter.
As this could be a minor breaking change for some users, it's necessary to notify them by updating the changelog and migration guide.
vitoyucepi
force-pushed
the
prometheus_port
branch
from
1ea6ff7
to
5efb598
Compare
|
Is this ready for merge? |
|
Yes, this PR is ready to be merged. |
|
Merged thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's good practice to allocate a specific port for each individual Prometheus metrics exporter.
This commit changes port
9090, which is used by the prometheus server itself, to9599, which is used by an unavailable https://github.com/marco-m/pirograph exporter.After merging this PR, the next step will be to change the wiki page https://github.com/prometheus/prometheus/wiki/Default-port-allocations.
Additional
#3772