-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add operation to generate CUE files. #3620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been waiting for this! Thanks!
Couple of remarks:
- I think this should go on the extra lib
- Are you interested in extracting the time split logic into its own function (provided we don't have one already!)
- Can we add test to see what the file looks like?
- Can we add parameters to make it work with infinite sources? Like keeping the last
n
entries? Could be disabled by default. - Can we make file change atomic? Otherwise you will run into situations where a partial file might be read. This happened with HLS outputs. You could factor out this code from
output.hls
:
Fun.protect
~finally:(fun () -> try Sys.remove tmp_file with _ -> ())
(fun () ->
(try Unix.rename tmp_file filename
with Unix.Unix_error (Unix.EXDEV, _, _) ->
self#log#important
"Rename failed! Directory for temporary files appears to be \
on a different file system. Please set it to the same one \
using `temp_dir` argument to guarantee atomic file \
operations!";
Utils.copy ~mode ~perms tmp_file filename;
Sys.remove tmp_file);
I think I have taken most of your suggestions in account. I propose that we merge as is and improve if usecases do show up... |
src/libs/source.liq
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smimram: Looks like you assume hours:minutes:seconds for the INDEX times, but they are actually MM:SS:FF
(minutes, seconds, frames). Hydrogenaudio tells us there are 75 frames to a second: https://wiki.hydrogenaud.io/index.php?title=Cue_sheet#Most_often_used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frames are numbered 00…74.
@toots @smimram Please check 50da0a3#r1448803161 ( |
Thanks for the comments, I am starting a bugfix session on #3624... |
Fixes #3608.