Immutable metadata #3297
Merged
Immutable metadata #3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toots
force-pushed
the
immutable-metadata
branch
3 times, most recently
from
6c7bc21
to
bb9a737
Compare
toots
force-pushed
the
immutable-metadata
branch
2 times, most recently
from
8a165ae
to
c5b3ab1
Compare
toots
force-pushed
the
immutable-metadata
branch
from
c5b3ab1
to
40a8557
Compare
toots
force-pushed
the
immutable-metadata
branch
from
40a8557
to
9d0eb3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a regular time-old footgun: metadata in streams and frames are mutable, which has lead to countless confusion where its content gets changed somewhere and triggers issues somewhere else.
This PR makes metadata immutable, reusing the same API as with methods. The main difference is that it will not allow multiple metadata with the same name, which seems reasonable and expected actually.