-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDL log verbosity conf. #2913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toots
force-pushed
the
sdl-logs-verbosity
branch
from
February 20, 2023 16:27
c8a65d7
to
1fa3e96
Compare
smimram
force-pushed
the
sdl-logs-verbosity
branch
from
July 28, 2023 08:41
1fa3e96
to
72057d0
Compare
Trying to get rid of
Note for later, the first print is there:
where
is let log fmt =
kpp (fun s -> ignore (log "%s" s)) fmt The culprit is actually |
Reported here: sanette/tsdl-image#8 |
This is linked before sdl-image and sdl-ttf and thus manages to silence their startup message.
smimram
approved these changes
Jul 28, 2023
toots
commented
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SDL log verbosity conf keys. However, they are not called early enough and I still see annoying logs when loading SDL stuff.