Fix all warnings.

[toots]

No description provided.

[toots]

There are some left-over warnings:

OCAMLOPT -c tools/utils.ml
File "tools/utils.ml", line 245, characters 4-17:
Warning 32: unused value get_backtrace.
....
OCAMLOPT -c configure.ml
File "configure.ml", line 123, characters 4-20:
Warning 32: unused value record_backtrace.

These can go only if we drop some code for OCaml <= 3.11.. I'm in favor of doing it..

[toots]

This is weird..

[dbaelde]

Yes, I think you need to keep this warning (because it says something useful: this piece of code is unfinished) or do some more modification. It may be okay to get rid of t' because the reference to t is used to keep track of time. I don't know why there is a reference, maybe to use it at the end after aux has returned.. but right now, the last update is useless because the ref is forgotten right after.

[toots]

I don't know what last update you have in mind but after re-reading this code, it looks fine to me.

[dbaelde]

I looked at the code again. It didn't make sense at first, but now it does, and I believe that my previous comment was misleaded. The reference t keeps track of the time in the metadata stream, and lives through all calls of fill. I don't see any problem with this code. Thanks!

[smimram]

From the specification, it's a bug if pos is not used, it should...

[dbaelde]

@toots would it be difficult to separate trivial stuff from all those changes that we commented on? It'd be nice to get the obvious changes out of the way to discuss the functions that need real fixing.

Also, I'll try to compile the branch on a relatively old OCaml. I believe I have 3.12 on my laptop, which doesn't have a Debian yet. It does not issue as many warnings as 4.0, but we should make sure there's no new syntax in the diff or anything like that.

[toots]

@dbaelde yeah, I'll do that later today. I'm all for 3.12 support but I'd like to drop 3.11 support. Is that ok for y'all?

[smimram]

I'd be fine with 3.12 support only.

[dbaelde]

I'm okay to support only OCaml >=3.12. However, I'd like it if this branch didn't accumulate more changes. Perhaps drop the compatibility code in master and merge back?

By the way I just tested a 3.12 build here and it worked fine.

[ghost]

git version, next: make init; make update

File "tools/utils.ml", line 109, characters 18-19:
Warning 27: unused variable c.
File "tools/wav_aiff.ml", line 213, characters 17-20:
Warning 27: unused variable pos.
File "tools/http.ml", line 245, characters 33-36:
Warning 27: unused variable len.
File "sources/playlist.ml", line 546, characters 27-34:
Warning 27: unused variable timeout.
File "tools/harbor.ml", line 449, characters 42-45:
Warning 27: unused variable len.
File "outputs/icecast2.ml", line 122, characters 19-157:
Warning 9: the following labels are not bound in this record pattern:
fill
Either bind these labels explicitly or add '; _' to the pattern.
File "outputs/icecast2.ml", line 131, characters 19-163:
Warning 9: the following labels are not bound in this record pattern:
fill
Either bind these labels explicitly or add '; _' to the pattern.
File "outputs/icecast2.ml", line 140, characters 19-157:
Warning 9: the following labels are not bound in this record pattern:
fill
Either bind these labels explicitly or add '; _' to the pattern.
File "outputs/icecast2.ml", line 213, characters 11-20:
Warning 6: labels were omitted in the application of this function.
File "outputs/icecast2.ml", line 599, characters 21-31:
Warning 6: labels were omitted in the application of this function.
File "outputs/icecast2.ml", line 25, characters 0-11:
Warning 33: unused open Dtools.
File "decoder/metadata_decoder.ml", line 70, characters 16-18:
Warning 27: unused variable t'.
File "decoder/aac_decoder.ml", line 131, characters 22-28:
Warning 27: unused variable length.
File "decoder/aac_decoder.ml", line 245, characters 21-26:
Warning 27: unused variable chans.
File "decoder/aac_decoder.ml", line 257, characters 18-24:
Warning 27: unused variable length.
File "lang/builtins_cry.ml", line 46, characters 11-20:
Warning 6: labels were omitted in the application of this function.
File "lang/builtins_cry.ml", line 23, characters 0-9:
Warning 33: unused open Lang.

[toots]

Thanks for the review! Indeed, some optional parts were not enabled locally here. I still haven't tested alsa and pulseaudio... I've fixed the above warnings, except those that need further discussion/coding..

[toots]

Okay, ready for the final merge!

[dbaelde]

Thanks for the work toots, it all looks fine to me!