Trim url in input.ffmpeg. Fixes: #3424

src/core/io/ffmpeg_io.ml

@@ -84,7 +84,7 @@ class input ?(name = "input.ffmpeg") ~autostart ~self_sync ~poll_delay ~debug
     method private start = self#connect
     method private stop = self#disconnect
     val mutable url = url
-    method url = url ()
+    method url = String.trim (url ())
     method set_url u = url <- u
     method buffer_length = Frame.seconds_of_audio (Generator.length self#buffer)
 

tests/streams/dune.inc

@@ -601,6 +601,49 @@
   (:run_test ../run_test.exe))
  (action (run %{run_test} ffmpeg-errors.liq liquidsoap %{test_liq} ffmpeg-errors.liq)))
 
+(rule
+  (alias tree-sitter-parse)
+  (deps
+   ffmpeg-trim.liq
+   ../../src/tooling/test-tree-sitter
+ )
+  (action
+    (chdir ../../src/tooling/test-tree-sitter/tree-sitter-liquidsoap
+     (ignore-stdout
+      (run npm exec tree-sitter -- parse ../../../../tests/streams/ffmpeg-trim.liq)))))
+
+(rule
+  (alias fmt)
+  (deps ffmpeg-trim.liq ../../src/tooling/test-prettier ../../src/tooling/prettier-plugin-liquidsoap/dist/liquidsoap.js)
+  (action
+    (progn
+      (with-stdout-to ffmpeg-trim.liq.prettier
+       (chdir ../../src/tooling/test-prettier
+         (run pnpm prettier --config ./config.json ../../../tests/streams/ffmpeg-trim.liq)))
+      (diff ffmpeg-trim.liq ffmpeg-trim.liq.prettier))))
+
+(rule
+ (alias citest)
+ (package liquidsoap)
+ (deps
+  ffmpeg-trim.liq
+  ./file1.mp3
+  ./file2.mp3
+  ./file3.mp3
+  ./jingle1.mp3
+  ./jingle2.mp3
+  ./jingle3.mp3
+  ./file1.png
+  ./file2.png
+  ./jingles
+  ./playlist
+  ./huge_playlist
+  ../../src/bin/liquidsoap.exe
+  (package liquidsoap)
+  (:test_liq ../test.liq)
+  (:run_test ../run_test.exe))
+ (action (run %{run_test} ffmpeg-trim.liq liquidsoap %{test_liq} ffmpeg-trim.liq)))
+
 (rule
   (alias tree-sitter-parse)
   (deps

tests/streams/ffmpeg-trim.liq

@@ -0,0 +1,13 @@
+def f() =
+  def on_error(_) =
+    test.fail()
+  end
+
+  # Test string.trim on url input.
+  output.dummy(
+    input.ffmpeg(on_connect=test.pass, on_error=on_error, " ./file1.mp3\n"),
+    fallible=true
+  )
+end
+
+test.check(f)