Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class inheritance fix in lang_FA and lang_ID #524

Closed
wants to merge 2 commits into from
Closed

class inheritance fix in lang_FA and lang_ID #524

wants to merge 2 commits into from

Conversation

tahzeer
Copy link

@tahzeer tahzeer commented Jun 23, 2023 •
edited
Loading

Fixes #522 by changes to lang_FA.py and lang_ID.py

Changes proposed in this pull request:

  • class Num2Words_ID now inherits from class Num2Words_Base
  • class Num2Words_FA now inherits from class Num2Words_Base

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

from num2words import num2words
d='5'
print(num2words(d, lang='fa')) # must print "پنج"

@Inokinoki
Copy link

ping this fix: is this ready to merge?

@tahzeer tahzeer closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Num2Word_FA' object has no attribute 'str_to_number'
3 participants
@tahzeer @Inokinoki @mrodriguezg1991