Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lang By Added #506

Merged
merged 20 commits into from
Oct 17, 2023
Merged

Conversation

SkiBY
Copy link
Contributor

@SkiBY SkiBY commented Mar 21, 2023

Changes proposed in this pull request:

Belarusian Language added

Status

READY

How to verify this change

Tests are written, but should be checked by another person

Additional notes

Small change in RU section for currency BYN

to be reverted(?)
@SkiBY SkiBY force-pushed the by_language_added branch 3 times, most recently from 65ff8ff to bbd0852 Compare March 21, 2023 09:45
tox.ini is changed!!! there is to much old code, to use isort and flake8 in 310 tests only
@coveralls
Copy link

coveralls commented Mar 21, 2023

Coverage Status

coverage: 97.477% (+0.04%) from 97.442% when pulling 54b9701 on SkiBY:by_language_added into 305242f on savoirfairelinux:master.

num2words/lang_BY.py Outdated Show resolved Hide resolved
num2words/lang_BY.py Outdated Show resolved Hide resolved
num2words/lang_BY.py Outdated Show resolved Hide resolved
num2words/lang_BY.py Outdated Show resolved Hide resolved
num2words/lang_BY.py Outdated Show resolved Hide resolved
num2words/lang_BY.py Outdated Show resolved Hide resolved
num2words/lang_BY.py Outdated Show resolved Hide resolved
num2words/lang_BY.py Outdated Show resolved Hide resolved
num2words/lang_BY.py Outdated Show resolved Hide resolved
@SkiBY
Copy link
Contributor Author

SkiBY commented Mar 24, 2023

@veryberry please recheck

veryberry
veryberry previously approved these changes Mar 30, 2023
Copy link

@veryberry veryberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

num2words/lang_BY.py Outdated Show resolved Hide resolved
num2words/lang_BY.py Outdated Show resolved Hide resolved
num2words/lang_BY.py Outdated Show resolved Hide resolved
num2words/lang_BY.py Outdated Show resolved Hide resolved
@SkiBY
Copy link
Contributor Author

SkiBY commented Jun 21, 2023

@yorlov updated, corrected, some gender bugs corrected thanks to DD
coverage increased, ready to be approved, I hope

Copy link

@Spaider Spaider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denis is here, Belarusian-speaking guy.
This MR looks good to me.

@SkiBY
Copy link
Contributor Author

SkiBY commented Aug 17, 2023

@mrodriguezg1991 could you please approve it?

@mrodriguezg1991
Copy link
Contributor

@mrodriguezg1991 could you please approve it?

@SkiBY you need to enable isort and flake validation in order to pass the test, the test for this MR were successful because the validation was removed, once this is solve i will approve, sorry for any inconvenience and thanks for taking the time to contribute to the project

@SkiBY
Copy link
Contributor Author

SkiBY commented Aug 17, 2023

@mrodriguezg1991 could you please approve it?

@SkiBY you need to enable isort and flake validation in order to pass the test, the test for this MR were successful because the validation was removed, once this is solve i will approve, sorry for any inconvenience and thanks for taking the time to contribute to the project

reformatted
flake8 and isort locally passed

@SkiBY
Copy link
Contributor Author

SkiBY commented Oct 16, 2023

@mrodriguezg1991 could you please review this PR?

@mrodriguezg1991
Copy link
Contributor

@mrodriguezg1991 could you please review this PR?

Hello, Can you please review previous comments? This PR removes the isort and flake8 validation, you need too fix that in order to merge this changes, thanks for taking the time to contribute

[FIX]isort and flake returned
@SkiBY
Copy link
Contributor Author

SkiBY commented Oct 16, 2023

@mrodriguezg1991 could you please review this PR?

Hello, Can you please review previous comments? This PR removes the isort and flake8 validation, you need too fix that in order to merge this changes, thanks for taking the time to contribute

Sorry @mrodriguezg1991 , I read it in opposite way.
tox.ini restored

@SkiBY
Copy link
Contributor Author

SkiBY commented Oct 17, 2023

@mrodriguezg1991 touched code for re-run - all checks are passed. Probably, yesterday there were problems with Actions?

tox.ini Outdated Show resolved Hide resolved
@mrodriguezg1991 mrodriguezg1991 merged commit d7d80f2 into savoirfairelinux:master Oct 17, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants