-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lang By Added #506
Lang By Added #506
Conversation
to be reverted(?)
65ff8ff
to
bbd0852
Compare
tox.ini is changed!!! there is to much old code, to use isort and flake8 in 310 tests only
bbd0852
to
ab5c132
Compare
@veryberry please recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
…age_added # Conflicts: # num2words/__init__.py
small gender fixes
small gender fixes
@yorlov updated, corrected, some gender bugs corrected thanks to DD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Denis is here, Belarusian-speaking guy.
This MR looks good to me.
@mrodriguezg1991 could you please approve it? |
@SkiBY you need to enable isort and flake validation in order to pass the test, the test for this MR were successful because the validation was removed, once this is solve i will approve, sorry for any inconvenience and thanks for taking the time to contribute to the project |
reformatted |
@mrodriguezg1991 could you please review this PR? |
Hello, Can you please review previous comments? This PR removes the isort and flake8 validation, you need too fix that in order to merge this changes, thanks for taking the time to contribute |
[FIX]isort and flake returned
1b5299c
to
1251406
Compare
Sorry @mrodriguezg1991 , I read it in opposite way. |
0551d20
to
1251406
Compare
@mrodriguezg1991 touched code for re-run - all checks are passed. Probably, yesterday there were problems with Actions? |
Changes proposed in this pull request:
Belarusian Language added
Status
READY
How to verify this change
Tests are written, but should be checked by another person
Additional notes
Small change in RU section for currency BYN