Adding genders for Russian language #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkiBY
approved these changes
Mar 21, 2023
SkiBY
reviewed
Mar 21, 2023
SkiBY
suggested changes
Mar 21, 2023
SkiBY
reviewed
Mar 21, 2023
mrodriguezg1991
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # by Khramtsov Dmitry
Changes proposed in this pull request:
Status
How to verify this change
here or here
Additional notes
The current version already had feminine logic in the currency, but we couldn't pass gender as an argument.
I also changed the plural function - it gives the same result, but the function is shorter and clearer.