forked from pulsar-edit/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more scopes #2
Closed
claytonrcarter
wants to merge
8
commits into
savetheclocktower:add-php-grammar
from
claytonrcarter:add-php-grammar#crc-2
Closed
Add more scopes #2
claytonrcarter
wants to merge
8
commits into
savetheclocktower:add-php-grammar
from
claytonrcarter:add-php-grammar#crc-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claytonrcarter
commented
Jan 12, 2024
packages/language-php/grammars/tree-sitter/queries/highlights.scm
Outdated
Show resolved
Hide resolved
eg $foo->bar, in addition to $foo->$bar
claytonrcarter
force-pushed
the
add-php-grammar#crc-2
branch
from
January 12, 2024 22:33
47ba1b7
to
f8d0043
Compare
This was referenced Jan 12, 2024
OK, I updated #852 with all this feedback, including a few other things (like scoping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I had to open this here because your branch only exists in your repo, not on the main pulsar repo, which I guess makes sense. I did not add tests for these, but I did follow the sweet instructions you posted to make these edits and watch the highlights update live. 🪄
I think the commits speak for themselves, but the gist is:
interface
abstract
$foo->bar
,Foo::bar
andFoo::$bar
use Foo
in a class, not as a namespace import