Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo infrastructure #5

Merged
merged 4 commits into from
Feb 11, 2021
Merged

Repo infrastructure #5

merged 4 commits into from
Feb 11, 2021

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Feb 11, 2021 •
edited
Loading

  • Diktat code analysis
  • Detekt code analysis
  • Git hooks
  • Fixed code style

@petertrr
Infra
0938c2e 
### What's done:
* detekt
* diktat
* code style
* git hooks
@petertrr
Infra
7a04971 
### What's done:
* diktat
@codecov
Copy link

codecov bot commented Feb 11, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@c4e4590). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #5   +/-   ##
=========================================
  Coverage          ?   92.75%           
  Complexity        ?       11           
=========================================
  Files             ?        4           
  Lines             ?       69           
  Branches          ?        1           
=========================================
  Hits              ?       64           
  Misses            ?        4           
  Partials          ?        1
Flag Coverage Δ Complexity Δ
unittests 92.75% <0.00%> (?) 0.00% <0.00%> (?%)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4e4590...88088ba. Read the comment docs.

@petertrr
Infra
627d13c 
### What's done:
* diktat
@petertrr
Infra
88088ba 
### What's done:
* diktat
orchestr7
orchestr7 approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit 31ce1b6 into master Feb 11, 2021
@petertrr petertrr deleted the infra/repo-infrastructure branch February 11, 2021 11:53
@petertrr petertrr added this to the SAVE-cloud MVP milestone Feb 20, 2021
nulls added a commit that referenced this pull request Jul 26, 2022
@nulls
fixed notes after self review #5
0456dc5
nulls added a commit that referenced this pull request Jul 28, 2022
@nulls
fixed notes after self review #5
47e3e35
nulls added a commit that referenced this pull request Aug 3, 2022
@nulls
review note #5
2167d02
nulls added a commit that referenced this pull request Aug 11, 2022
@nulls
Execution run by contest id #5
651cd2e
nulls added a commit that referenced this pull request Aug 11, 2022
@nulls
Execution run by contest id #5
9141645
nulls added a commit that referenced this pull request Aug 11, 2022
@nulls
Execution run by contest id #5
f851da9
nulls added a commit that referenced this pull request Aug 11, 2022
@nulls
Execution run by contest id #5
1095445
nulls added a commit that referenced this pull request Aug 11, 2022
@nulls
Execution run by contest id #5
9565075
nulls added a commit that referenced this pull request Aug 12, 2022
@nulls
Execution run by contest id #5
ae7be36
nulls added a commit that referenced this pull request Aug 16, 2022
@nulls
Execution run by contest id #5
8046f5f
orchestr7 added a commit that referenced this pull request Aug 1, 2023
@orchestr7
Reworking settings view #5
1654edf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orchestr7 orchestr7 orchestr7 approved these changes

@aktsay6 aktsay6 Awaiting requested review from aktsay6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
SAVE-cloud MVP
Development

Successfully merging this pull request may close these issues.
2 participants
@petertrr @orchestr7