-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: docker manager #4
Conversation
* Added .gitignore, .gitattributes * Added junit platform * Added gradle wrapper
### What's done: * WIP
### What's done: * CI via github actions * Added jacoco configuration * Added tests for ContainerManager
### What's done: * Bump gradle version * Fix build_and_test.yml
### What's done: * Use gvisor in tests
### What's done: * Use gvisor in tests
fun setUp() { | ||
containerManager = if (System.getProperty("os.name").startsWith("Windows")) { | ||
// for docker inside WSL2 use it's eth0 network IP | ||
ContainerManager("tcp://172.20.51.70:2375") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this IP for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is IP of WLS2 network, to communicate with docker daemon inside WLS2 from project opened under Windows. At least until IDEA supports working with projects from WSL
### What's done: * Added sample common class
### What's done: * Refactoring * Added use for AutoCloseable resources
e7c4e23
to
7435113
Compare
### What's done: * Refactoring & cleanup
### What's done: * Build image
4905192
to
8d0d20b
Compare
### What's done: * Extracted orchestrator to separate subproject * Extracted versions to buildSrc
### What's done: * Enabled codecov
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=========================================
Coverage ? 95.52%
Complexity ? 11
=========================================
Files ? 3
Lines ? 67
Branches ? 1
=========================================
Hits ? 64
Misses ? 2
Partials ? 1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
### What's done: * Enabled codecov
abff774
to
3e5b2c3
Compare
What's done: