Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: docker manager #4

Merged
merged 14 commits into from
Feb 11, 2021
Merged

WIP: docker manager #4

merged 14 commits into from
Feb 11, 2021

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Feb 5, 2021

What's done:

  • Created subproject for save-orchestrator
  • Added .gitignore, .gitattributes
  • Added junit platform
  • Added gradle wrapper
  • Use docker java API to create containers
  • CI via github actions, including gvisor installation
  • Added jacoco configuration
  • Added tests for ContainerManager

petertrr and others added 7 commits February 3, 2021 14:53
* Added .gitignore, .gitattributes
* Added junit platform
* Added gradle wrapper
### What's done:
* WIP
### What's done:
* CI via github actions
* Added jacoco configuration
* Added tests for ContainerManager
### What's done:
* Bump gradle version
* Fix build_and_test.yml
### What's done:
* Use gvisor in tests
### What's done:
* Use gvisor in tests
fun setUp() {
containerManager = if (System.getProperty("os.name").startsWith("Windows")) {
// for docker inside WSL2 use it's eth0 network IP
ContainerManager("tcp://172.20.51.70:2375")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this IP for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is IP of WLS2 network, to communicate with docker daemon inside WLS2 from project opened under Windows. At least until IDEA supports working with projects from WSL

### What's done:
* Added sample common class
### What's done:
* Refactoring
* Added use for AutoCloseable resources
### What's done:
* Refactoring & cleanup
### What's done:
* Build image
### What's done:
* Extracted orchestrator to separate subproject
* Extracted versions to buildSrc
### What's done:
* Enabled codecov
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@fc3c508). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   95.52%           
  Complexity        ?       11           
=========================================
  Files             ?        3           
  Lines             ?       67           
  Branches          ?        1           
=========================================
  Hits              ?       64           
  Misses            ?        2           
  Partials          ?        1           
Flag Coverage Δ Complexity Δ
unittests 95.52% <0.00%> (?) 0.00% <0.00%> (?%)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc3c508...3e5b2c3. Read the comment docs.

Copy link
Collaborator

@aktsay6 aktsay6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

### What's done:
* Enabled codecov
@petertrr petertrr merged commit c4e4590 into master Feb 11, 2021
@petertrr petertrr deleted the feature/docker-manager branch February 11, 2021 09:44
@petertrr petertrr added this to the SAVE-cloud MVP milestone Feb 20, 2021
nulls added a commit that referenced this pull request Jul 26, 2022
nulls added a commit that referenced this pull request Jul 28, 2022
nulls added a commit that referenced this pull request Aug 2, 2022
nulls added a commit that referenced this pull request Aug 3, 2022
nulls added a commit that referenced this pull request Aug 11, 2022
nulls added a commit that referenced this pull request Aug 11, 2022
nulls added a commit that referenced this pull request Aug 11, 2022
nulls added a commit that referenced this pull request Aug 11, 2022
nulls added a commit that referenced this pull request Aug 11, 2022
nulls added a commit that referenced this pull request Aug 11, 2022
nulls added a commit that referenced this pull request Aug 12, 2022
nulls added a commit that referenced this pull request Aug 16, 2022
nulls added a commit that referenced this pull request Aug 16, 2022
nulls added a commit that referenced this pull request Sep 12, 2022
nulls added a commit that referenced this pull request Oct 3, 2022
nulls added a commit that referenced this pull request Jan 20, 2023
orchestr7 added a commit that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants