Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP for gradle script #885

Merged
merged 5 commits into from
May 13, 2021
Merged

FP for gradle script #885

merged 5 commits into from
May 13, 2021

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented May 13, 2021

What's done:

### What's done:
Fixed logic in `RunScriptRule`
Removed handler for header in gradle script
@kentr0w kentr0w added the bug Something isn't working label May 13, 2021
@kentr0w kentr0w requested review from petertrr and aktsay6 May 13, 2021 08:47
kentr0w added 2 commits May 13, 2021 11:48
### What's done:
Removed useless line
### What's done:
Fixed according to our code style
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #885 (b9f24e8) into master (14d97a3) will increase coverage by 0.10%.
The diff coverage is 95.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #885      +/-   ##
============================================
+ Coverage     83.94%   84.05%   +0.10%     
- Complexity     2308     2311       +3     
============================================
  Files           100      100              
  Lines          5893     5894       +1     
  Branches       1739     1742       +3     
============================================
+ Hits           4947     4954       +7     
+ Misses          261      255       -6     
  Partials        685      685              
Flag Coverage Δ Complexity Δ
unittests 84.05% <95.00%> (+0.10%) 2311.00 <10.00> (+3.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../cqfn/diktat/ruleset/rules/chapter6/RunInScript.kt 92.30% <93.33%> (+19.89%) 16.00 <6.00> (+2.00)
...leset/rules/chapter2/comments/HeaderCommentRule.kt 86.59% <100.00%> (ø) 46.00 <4.00> (+1.00)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 85.77% <100.00%> (+0.22%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d97a3...b9f24e8. Read the comment docs.

@petertrr petertrr added this to the 0.6.0 milestone May 13, 2021
@kentr0w kentr0w merged commit 2662d66 into master May 13, 2021
@kentr0w kentr0w deleted the bugfix/rule-in-gradle-sctipt branch May 13, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FP for gradle scripts
2 participants