Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Magic Number in test #879

Merged
merged 4 commits into from
May 12, 2021
Merged

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented May 11, 2021

### What's done:
Added option
Added test
@kentr0w kentr0w added the enhancement New feature or request label May 11, 2021
@kentr0w kentr0w requested review from petertrr and aktsay6 May 11, 2021 15:04
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #879 (5ca01f2) into master (6de6a62) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #879      +/-   ##
============================================
- Coverage     83.53%   83.52%   -0.01%     
- Complexity     2210     2211       +1     
============================================
  Files           101      101              
  Lines          5677     5681       +4     
  Branches       1620     1624       +4     
============================================
+ Hits           4742     4745       +3     
  Misses          256      256              
- Partials        679      680       +1     
Flag Coverage Δ Complexity Δ
unittests 83.52% <83.33%> (-0.01%) 2211.00 <4.00> (+1.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...n/diktat/ruleset/rules/chapter3/MagicNumberRule.kt 85.10% <80.00%> (-0.95%) 28.00 <4.00> (+1.00) ⬇️
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 84.77% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9b54f...5ca01f2. Read the comment docs.

### What's done:
Fixed according to our code style
@kentr0w kentr0w merged commit 2b17b31 into master May 12, 2021
@kentr0w kentr0w deleted the feature/magic-number-not-work-in-test branch May 12, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There should be an option to disable MAGIC_NUMBER rule in test sources
2 participants