Fix bug in PackageNaming for kotlin scripts #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Changed logic * Updated smoke tests
### What's done: * Changed logic * Updated smoke tests
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
============================================
- Coverage 81.07% 81.06% -0.02%
+ Complexity 2287 2286 -1
============================================
Files 100 100
Lines 5855 5857 +2
Branches 1813 1814 +1
============================================
+ Hits 4747 4748 +1
Misses 286 286
- Partials 822 823 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
orchestr7
reviewed
Apr 29, 2021
| @@ -0,0 +1,19 @@ | |||
|
|
|||
There was a problem hiding this comment.
discussed, need to add test for kts with package name
### What's done: * Changed logic * Updated smoke tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #861