Incorrect fix of null-safety rule #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: Fixed bug Created tests
Codecov Report
@@ Coverage Diff @@
## master #857 +/- ##
============================================
- Coverage 80.43% 80.42% -0.01%
- Complexity 2185 2199 +14
============================================
Files 101 101
Lines 5637 5671 +34
Branches 1734 1747 +13
============================================
+ Hits 4534 4561 +27
- Misses 264 265 +1
- Partials 839 845 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: Fixed bug Fixed according to our code style
petertrr
requested changes
Apr 28, 2021
diktat-rules/src/test/resources/test/paragraph4/null_checks/IfConditionNullCheckExpected.kt
Outdated
Show resolved
Hide resolved
petertrr
requested changes
Apr 29, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/resources/test/paragraph4/null_checks/IfConditionBreakCheckTest.kt
Show resolved
Hide resolved
### What's done: Fixed after review
petertrr
reviewed
Apr 29, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/resources/test/paragraph4/null_checks/IfConditionBreakCheckTest.kt
Outdated
Show resolved
Hide resolved
kgevorkyan
reviewed
Apr 30, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed logic and added more tests
### What's done: Fixed according to our code-style
petertrr
approved these changes
Apr 30, 2021
…x-null-safety # Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: