Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jcenter from the list of dependency repositories #846

Merged
merged 3 commits into from
Apr 26, 2021

Conversation

petertrr
Copy link
Member

What's done:

  • Removed jcenter from pom.xml and build.gradle.kts

jcenter will be shut down soon; it was originally introduced in diktat for using dokka, but is probably no more needed

### What's done:
* Removed jcenter from pom.xml and build.gradle.kts
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #846 (463a7da) into master (93b7bbe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #846   +/-   ##
=========================================
  Coverage     81.01%   81.01%           
  Complexity     2292     2292           
=========================================
  Files           100      100           
  Lines          5840     5840           
  Branches       1815     1815           
=========================================
  Hits           4731     4731           
  Misses          286      286           
  Partials        823      823           
Flag Coverage Δ Complexity Δ
unittests 81.01% <ø> (ø) 2292.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b7bbe...463a7da. Read the comment docs.

@petertrr petertrr marked this pull request as ready for review April 26, 2021 07:17
Copy link
Collaborator

@aktsay6 aktsay6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about src/test/resources/test/smoke/build.gradle_.kts this path?

@petertrr
Copy link
Member Author

What about src/test/resources/test/smoke/build.gradle_.kts this path?

That's just a resource for smoke testing. This script is never actually executed.

Copy link
Collaborator

@aktsay6 aktsay6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit 60dac69 into master Apr 26, 2021
@petertrr petertrr deleted the infra/remove-jcenter-repo branch April 26, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants