Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test class for DummyWarning #810

Merged
merged 2 commits into from
Mar 25, 2021

Conversation

kgevorkyan
Copy link
Member

What's done:

  • Added test class for DummyWarning, which shows the general form of how to test your rule
  • Add newline in guide-chapter-1, since table wasn't displayed

### What's done:
* Added test class for DummyWarning, which shows the general form of how to test your rule
* Add newline in guide-chapter-1, since table wasn't displayed
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #810 (ae26311) into master (ee33cfd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #810   +/-   ##
=========================================
  Coverage     80.95%   80.95%           
  Complexity     2248     2248           
=========================================
  Files            99       99           
  Lines          5738     5738           
  Branches       1783     1783           
=========================================
  Hits           4645     4645           
  Misses          286      286           
  Partials        807      807           
Flag Coverage Δ Complexity Δ
unittests 80.95% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee33cfd...ae26311. Read the comment docs.

Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should be useful for newcomers.
I guess you can also write a small instruction in our readme of how to work with DummyWarning for your experiments

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can run mvn diktat:fix@diktat to fix code style issues. Also, don't forget to select 'squash and merge'.

### What's done:
* Change indention in DummyWarningTest from 16 spaces to 12 spaces
@kgevorkyan kgevorkyan merged commit 9a2a218 into master Mar 25, 2021
@kgevorkyan kgevorkyan deleted the feature/add_test_for_dummywarning branch March 25, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants