Fix Conflicting TOO_MANY_BLANK_LINES and BRACES_BLOCK_STRUCTURE_ERROR with empty block #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with empty block ### What's done: * Fixed Conflicting TOO_MANY_BLANK_LINES and BRACES_BLOCK_STRUCTURE_ERROR with empty block in lambda
Cheshiriks
force-pushed
the
bugfix/blank-lines-in-lambda
branch
from
f0aeebc to
9544845
Compare
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
============================================
+ Coverage 80.91% 80.93% +0.01%
- Complexity 2204 2213 +9
============================================
Files 98 98
Lines 5670 5685 +15
Branches 1756 1763 +7
============================================
+ Hits 4588 4601 +13
Misses 285 285
- Partials 797 799 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
requested changes
Mar 11, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/BlockStructureBraces.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/resources/test/smoke/src/main/kotlin/Example8Expected.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/BlankLinesRule.kt
Outdated
Show resolved
Hide resolved
… with empty block ### What's done: * Fixed Conflicting TOO_MANY_BLANK_LINES and BRACES_BLOCK_STRUCTURE_ERROR with empty block in lambda
Cheshiriks
force-pushed
the
bugfix/blank-lines-in-lambda
branch
from
798a791 to
7a64998
Compare
petertrr
requested changes
Mar 12, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/BlockStructureBraces.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/resources/test/smoke/src/main/kotlin/Example8Expected.kt
Outdated
Show resolved
Hide resolved
… with empty block ### What's done: * Fixed Conflicting TOO_MANY_BLANK_LINES and BRACES_BLOCK_STRUCTURE_ERROR with empty block in lambda
orchestr7
requested changes
Mar 12, 2021
petertrr
requested changes
Mar 12, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/EmptyBlock.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/EmptyBlock.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/BlockStructureBraces.kt
Show resolved
Hide resolved
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/EmptyBlockWarnTest.kt
Outdated
Show resolved
Hide resolved
… with empty block ### What's done: * Fixed Conflicting TOO_MANY_BLANK_LINES and BRACES_BLOCK_STRUCTURE_ERROR with empty block in lambda
petertrr
approved these changes
Mar 15, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/EmptyBlock.kt
Outdated
Show resolved
Hide resolved
… with empty block ### What's done: * Fixed Conflicting TOO_MANY_BLANK_LINES and BRACES_BLOCK_STRUCTURE_ERROR with empty block in lambda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
closes Conflicting TOO_MANY_BLANK_LINES and BRACES_BLOCK_STRUCTURE_ERROR with empty block #791