Fix NPE in NewLineRule #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Fixed NPE in NewLineRule for lambda list argument
Cheshiriks
force-pushed
the
bugfix/npe-newline
branch
from
b5592bd to
f03adbd
Compare
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
============================================
- Coverage 80.92% 80.91% -0.01%
- Complexity 2203 2204 +1
============================================
Files 98 98
Lines 5666 5670 +4
Branches 1753 1756 +3
============================================
+ Hits 4585 4588 +3
Misses 285 285
- Partials 796 797 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
orchestr7
requested changes
Mar 8, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
Outdated
Show resolved
Hide resolved
### What's done: * Fixed NPE in NewLineRule for lambda list argument
petertrr
requested changes
Mar 9, 2021
diktat-rules/src/test/resources/test/paragraph3/newlines/ListArgumentLambdaTest.kt
Show resolved
Hide resolved
### What's done: * Fixed NPE in NewLineRule for lambda list argument
Cheshiriks
force-pushed
the
bugfix/npe-newline
branch
from
c98ed21 to
4fdb427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
closes NPE: Internal error has occurred in newlines #789