Fix all Warnings

[kentr0w]

What's done:

Fixed all warnings
closes #769

[petertrr]

Also, did you check, whether there is a flag that makes kotlin compiler threat warnings as errors?

[orchestr7]

Denis, please be more careful and pay attention to the details

[petertrr]

@kentr0w any progress on this?

[codecov]

Codecov Report

Merging #781 (8ce3cc8) into master (4c82083) will decrease coverage by 0.63%.
The diff coverage is 82.22%.

@@             Coverage Diff              @@
##             master     #781      +/-   ##
============================================
- Coverage     81.06%   80.43%   -0.64%     
+ Complexity     2286     2185     -101     
============================================
  Files           100      101       +1     
  Lines          5857     5637     -220     
  Branches       1814     1734      -80     
============================================
- Hits           4748     4534     -214     
+ Misses          286      264      -22     
- Partials        823      839      +16     

Flag	Coverage Δ	Complexity Δ
unittests	80.43% <82.22%> (-0.64%)	2185.00 <2.00> (-101.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
...t/common/config/reader/JsonResourceConfigReader.kt	45.45% <ø> (ø)	3.00 <0.00> (ø)
...fn/diktat/common/config/rules/RulesConfigReader.kt	35.29% <ø> (+0.67%)	4.00 <0.00> (ø)
...rg/cqfn/diktat/plugin/gradle/DiktatGradlePlugin.kt	100.00% <ø> (ø)	2.00 <0.00> (ø)
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt	86.41% <ø> (-0.17%)	20.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt	98.59% <ø> (+0.66%)	12.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/dummy/DummyWarning.kt	100.00% <ø> (ø)	2.00 <0.00> (ø)
.../diktat/ruleset/rules/chapter1/IdentifierNaming.kt	75.31% <0.00%> (-6.90%)	87.00 <0.00> (-4.00)
.../ruleset/rules/chapter2/kdoc/CommentsFormatting.kt	65.77% <ø> (-3.61%)	76.00 <0.00> (ø)
.../diktat/ruleset/rules/chapter2/kdoc/KdocMethods.kt	84.61% <ø> (-3.13%)	70.00 <0.00> (-4.00)
...n/diktat/ruleset/rules/chapter3/MagicNumberRule.kt	78.04% <ø> (-2.91%)	26.00 <0.00> (-2.00)
... and 92 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c82083...8ce3cc8. Read the comment docs.

[orchestr7]

Also, did you check, whether there is a flag that makes kotlin compiler threat warnings as errors?

  <plugin>
                <artifactId>kotlin-maven-plugin</artifactId>
                <groupId>org.jetbrains.kotlin</groupId>
                <version>${kotlin.version}</version>
                <!-- ... -->
                <configuration>
                    <args>
                        <arg>-Werror</arg>
                    </args>
                </configuration>
            </plugin>

[orchestr7]

for gradle:

compileKotlin {
    kotlinOptions.allWarningsAsErrors = true
}

[orchestr7]

treat warns as errors

[orchestr7]

Lgtm