Magic Number

[kentr0w]

What's done:

Magic number

Actions checklist

• Implemented Rule, added Warnings
• Added tests on checks
• Added tests on fixers
• Updated diktat-analysis.yml
• Updated available-rules.md
• closes Magic number: rule is not supported in the diktat #767

[codecov]

Codecov Report

Merging #772 (f290802) into master (8a7a2df) will increase coverage by 0.02%.
The diff coverage is 81.81%.

@@             Coverage Diff              @@
##             master     #772      +/-   ##
============================================
+ Coverage     80.92%   80.95%   +0.02%     
- Complexity     2221     2248      +27     
============================================
  Files            98       99       +1     
  Lines          5694     5738      +44     
  Branches       1767     1783      +16     
============================================
+ Hits           4608     4645      +37     
  Misses          286      286              
- Partials        800      807       +7     

Flag	Coverage Δ	Complexity Δ
unittests	80.95% <81.81%> (+0.02%)	0.00 <27.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
...g/cqfn/diktat/ruleset/rules/chapter3/LineLength.kt	86.60% <ø> (ø)	77.00 <0.00> (ø)
...n/diktat/ruleset/rules/chapter3/MagicNumberRule.kt	80.95% <80.95%> (ø)	27.00 <27.00> (?)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt	97.90% <100.00%> (+0.01%)	12.00 <0.00> (ø)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt	92.17% <100.00%> (+0.06%)	11.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt	81.45% <0.00%> (+0.40%)	0.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a7a2df...f290802. Read the comment docs.

[orchestr7]

what rule do we have in a code style for this. Will you add? Or we have existing?

[kentr0w]

No, we didn't have a rule for that. So I added this rule to chapter 3

[orchestr7]

Lgtm