Multiple error

[kentr0w]

What's done:

Added atomic counter
closes #751

[petertrr]

Did you figure out why it was possible? Body of lazy should have been executed only once, even with parallel execution. Counter fixes this behavior, of course, but it's always better to find a root cause. Did you try to reproduce it in maven, for example?

[kentr0w]

This was due to our List<RulesConfig>.getCommonConfiguration() function. To fix, I can make an atomic counter (as already done) or make a lazy extension property.

[petertrr]

I suggest to use lazy extension property, I think using a function there was by mistake.

[kentr0w]

Unfortunately, a lazy property requires storing state, and there is no way to add state to an existing object from an extension property.

[codecov]

Codecov Report

Merging #764 (b183c77) into master (208c1ed) will decrease coverage by 0.01%.
The diff coverage is 72.72%.

@@             Coverage Diff              @@
##             master     #764      +/-   ##
============================================
- Coverage     79.79%   79.78%   -0.02%     
- Complexity     2025     2032       +7     
============================================
  Files            97       97              
  Lines          5089     5090       +1     
  Branches       1626     1627       +1     
============================================
  Hits           4061     4061              
- Misses          246      247       +1     
  Partials        782      782              

Flag	Coverage Δ	Complexity Δ
unittests	79.78% <72.72%> (-0.02%)	0.00 <18.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
.../ruleset/rules/chapter3/files/FileStructureRule.kt	80.51% <ø> (ø)	77.00 <0.00> (ø)
...fn/diktat/common/config/rules/RulesConfigReader.kt	40.47% <25.00%> (-0.99%)	4.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/constants/Chapters.kt	60.86% <100.00%> (ø)	2.00 <0.00> (ø)
...qfn/diktat/ruleset/rules/chapter1/PackageNaming.kt	91.76% <100.00%> (ø)	35.00 <4.00> (ø)
...diktat/ruleset/rules/chapter2/kdoc/KdocComments.kt	78.90% <100.00%> (ø)	70.00 <6.00> (ø)
.../diktat/ruleset/rules/chapter2/kdoc/KdocMethods.kt	84.31% <100.00%> (ø)	70.00 <0.00> (ø)
...diktat/ruleset/rules/chapter3/TrailingCommaRule.kt	92.50% <100.00%> (ø)	26.00 <0.00> (ø)
...diktat/ruleset/rules/chapter6/AvoidUtilityClass.kt	68.42% <100.00%> (ø)	15.00 <5.00> (ø)
...uleset/rules/chapter6/classes/InlineClassesRule.kt	72.72% <100.00%> (ø)	23.00 <3.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 208c1ed...b183c77. Read the comment docs.