-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copyright as code #740
Copyright as code #740
Conversation
### What's done: Fixed bug, added comment and test
### What's done: Fixed according our code style
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
============================================
- Coverage 79.96% 79.94% -0.03%
- Complexity 1967 1971 +4
============================================
Files 94 94
Lines 5066 5075 +9
Branches 1623 1627 +4
============================================
+ Hits 4051 4057 +6
Misses 241 241
- Partials 774 777 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, try to avoid false positives by possibly creating false negatives? For example, don't try to parse comment if it doesn't contain =
or {}
or some other special symbols that don't usually occur in plain text
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter2/comments/CommentsRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter2/comments/CommentsRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter2/comments/CommentedCodeTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please set isCopyrightMandatory
in default config to false
### What's done: Fixed after review
### What's done: Fixed after review
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter2/comments/CommentedCodeTest.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed test
### What's done: Fixed test
### What's done: Fixed according to our code style
### What's done: Fixed regex
### What's done: Fixed this bug in another files
### What's done: Fixed according to our code style
### What's done: Fixed according to our code style
### What's done: Fixed according to our code style
### What's done: Fixed according to our code style
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter2/comments/CommentsRule.kt
Show resolved
Hide resolved
...ules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter6/classes/CompactInitialization.kt
Outdated
Show resolved
Hide resolved
...ules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter6/classes/CompactInitialization.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter2/comments/CommentedCodeTest.kt
Show resolved
Hide resolved
### What's done: Fixed after review
What's done: