Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright as code #740

Merged
merged 14 commits into from
Feb 2, 2021
Merged

Copyright as code #740

merged 14 commits into from
Feb 2, 2021

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Feb 1, 2021

What's done:

### What's done:
   Fixed bug, added comment and test
@kentr0w kentr0w added the bug Something isn't working label Feb 1, 2021
@kentr0w kentr0w requested review from petertrr and aktsay6 February 1, 2021 12:55
### What's done:
   Fixed according our code style
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #740 (ce74f67) into master (3293e8d) will decrease coverage by 0.02%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #740      +/-   ##
============================================
- Coverage     79.96%   79.94%   -0.03%     
- Complexity     1967     1971       +4     
============================================
  Files            94       94              
  Lines          5066     5075       +9     
  Branches       1623     1627       +4     
============================================
+ Hits           4051     4057       +6     
  Misses          241      241              
- Partials        774      777       +3     
Flag Coverage Δ Complexity Δ
unittests 79.94% <71.42%> (-0.03%) 0.00 <11.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 97.79% <ø> (ø) 12.00 <0.00> (ø)
...at/ruleset/rules/chapter2/comments/CommentsRule.kt 90.76% <71.42%> (-3.88%) 26.00 <11.00> (+4.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3293e8d...ce74f67. Read the comment docs.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, try to avoid false positives by possibly creating false negatives? For example, don't try to parse comment if it doesn't contain = or {} or some other special symbols that don't usually occur in plain text

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please set isCopyrightMandatory in default config to false

### What's done:
   Fixed after review
### What's done:
   Fixed after review
### What's done:
   Fixed test
### What's done:
   Fixed test
### What's done:
   Fixed according to our code style
### What's done:
   Fixed regex
### What's done:
   Fixed this bug in another files
### What's done:
   Fixed according to our code style
### What's done:
   Fixed according to our code style
### What's done:
   Fixed according to our code style
### What's done:
   Fixed according to our code style
### What's done:
   Fixed after review
@petertrr petertrr merged commit ed935c5 into master Feb 2, 2021
@petertrr petertrr deleted the bugfix/copyright-as-code branch February 2, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copyright added from default config causes COMMENTED_OUT_CODE trigger
2 participants