Wrapper in kts file #735
Merged
Wrapper in kts file #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: Created new rule, added tests
### What's done: Fixed according our checkers
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
============================================
- Coverage 81.30% 81.28% -0.02%
- Complexity 2133 2148 +15
============================================
Files 96 97 +1
Lines 5510 5542 +32
Branches 1700 1706 +6
============================================
+ Hits 4480 4505 +25
- Misses 265 271 +6
- Partials 765 766 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
aktsay6
requested changes
Feb 1, 2021
# Conflicts: # diktat-analysis.yml # diktat-rules/src/main/kotlin/generated/WarningNames.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt # diktat-rules/src/main/resources/diktat-analysis-huawei.yml # diktat-rules/src/main/resources/diktat-analysis.yml # info/available-rules.md
### What's done: Fixed according our code style
### What's done: Fixed according our code style
petertrr
requested changes
Feb 1, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter6/RunInScript.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed after review
### What's done: Fixed according to our code style
petertrr
requested changes
Feb 11, 2021
There was a problem hiding this comment.
I think we should reconsider this rule text. We can add a condition for *.gradle.kts files and jsut *.kts files: gradle files should have more things allowed on top level. Please try your rule on build.gradle.kts files we have available (in diktat-gradle-plugin, in docs, probably from other our projects) to see if they yield sane results.
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter6/RunInScript.kt
Show resolved
Hide resolved
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter6/RunInScriptWarnTest.kt
Show resolved
Hide resolved
### What's done: Added new logic to gradle plugin
petertrr
reviewed
Feb 16, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter6/RunInScript.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed after review
### What's done: Fixed bug with file path
### What's done: Fixed according to our code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Created new rule, added tests
Actions checklist
runin kotlin scripts #732