Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure. Split rules logic in rule-set into chapters #729

Merged
merged 3 commits into from
Jan 26, 2021

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Jan 26, 2021

What's done:

  • Rules are now split to chapters

This pull request closes #719

### What's done:
  * Rules are now split to chapters
@aktsay6 aktsay6 added the infrastructure Issues related to building the project, CI/CD, deployments etc. label Jan 26, 2021
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a lot of changed files. I guess should be ok.

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #729 (10cff4a) into master (c5d3db8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #729   +/-   ##
=========================================
  Coverage     80.17%   80.17%           
  Complexity     1913     1913           
=========================================
  Files            91       91           
  Lines          4937     4937           
  Branches       1580     1580           
=========================================
  Hits           3958     3958           
  Misses          238      238           
  Partials        741      741           
Flag Coverage Δ Complexity Δ
unittests 80.17% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 93.33% <ø> (ø) 11.00 <0.00> (ø)
...g/cqfn/diktat/ruleset/rules/chapter1/FileNaming.kt 86.36% <ø> (ø) 9.00 <0.00> (?)
.../diktat/ruleset/rules/chapter1/IdentifierNaming.kt 74.32% <ø> (ø) 84.00 <0.00> (?)
...qfn/diktat/ruleset/rules/chapter1/PackageNaming.kt 91.76% <ø> (ø) 35.00 <0.00> (?)
...at/ruleset/rules/chapter2/comments/CommentsRule.kt 94.64% <ø> (ø) 22.00 <0.00> (?)
...leset/rules/chapter2/comments/HeaderCommentRule.kt 82.79% <ø> (ø) 42.00 <0.00> (?)
.../ruleset/rules/chapter2/kdoc/CommentsFormatting.kt 65.77% <ø> (ø) 76.00 <0.00> (?)
...diktat/ruleset/rules/chapter2/kdoc/KdocComments.kt 78.90% <ø> (ø) 70.00 <0.00> (?)
...ktat/ruleset/rules/chapter2/kdoc/KdocFormatting.kt 72.98% <ø> (ø) 89.00 <0.00> (?)
.../diktat/ruleset/rules/chapter2/kdoc/KdocMethods.kt 84.31% <ø> (ø) 70.00 <0.00> (?)
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d3db8...10cff4a. Read the comment docs.

### What's done:
  * Rules are now split to chapters
### What's done:
  * Rules are now split to chapters
@aktsay6 aktsay6 merged commit c4c32b2 into master Jan 26, 2021
@aktsay6 aktsay6 deleted the bugfix/rules-to-chapter-folders(#719) branch January 26, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to building the project, CI/CD, deployments etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split rules logic in rule-set into chapters
2 participants