Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncAndSyncRule #707

Merged
merged 8 commits into from
Jan 18, 2021
Merged

AsyncAndSyncRule #707

merged 8 commits into from
Jan 18, 2021

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Jan 14, 2021

What's done:

Implemented rule, added tests and documentation

Actions checklist

### What's done:
   Implemented rule, added tests and documentation
@kentr0w kentr0w added the enhancement New feature or request label Jan 14, 2021
### What's done:
   Fixed according out code-style
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #707 (fcc5ad2) into master (526bc52) will increase coverage by 0.01%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #707      +/-   ##
============================================
+ Coverage     80.08%   80.09%   +0.01%     
- Complexity     1871     1887      +16     
============================================
  Files            88       89       +1     
  Lines          4870     4883      +13     
  Branches       1565     1566       +1     
============================================
+ Hits           3900     3911      +11     
  Misses          238      238              
- Partials        732      734       +2     
Flag Coverage Δ Complexity Δ
unittests 80.09% <84.61%> (+0.01%) 0.00 <16.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...at-rules/src/main/kotlin/generated/WarningNames.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../org/cqfn/diktat/ruleset/rules/AsyncAndSyncRule.kt 81.81% <81.81%> (ø) 16.00 <16.00> (?)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 97.70% <100.00%> (+0.01%) 11.00 <0.00> (ø)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 93.20% <100.00%> (+0.06%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 526bc52...fcc5ad2. Read the comment docs.

### What's done:
   Fixed according out code-style
### What's done:
   Fixed after review
### What's done:
   Fixed according our code style
### What's done:
   Fixed according our code style
### What's done:
   Fixed according our code style
@kentr0w kentr0w merged commit 373b609 into master Jan 18, 2021
@kentr0w kentr0w deleted the feature/runBlocking-async branch January 18, 2021 08:27
@orchestr7
Copy link
Member

@petertrr @kentr0w add it to the code style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid using runBlocking in asynchronous code
3 participants