Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the codestyle #702

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Updates to the codestyle #702

merged 2 commits into from
Jan 13, 2021

Conversation

orchestr7
Copy link
Member

What's done:

Regenerated the codestyle

### What's done:
Regenerated the codestyle
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #702 (f423bbd) into master (9bfac8a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #702   +/-   ##
=========================================
  Coverage     79.94%   79.94%           
  Complexity     1839     1839           
=========================================
  Files            87       87           
  Lines          4801     4801           
  Branches       1549     1549           
=========================================
  Hits           3838     3838           
  Misses          241      241           
  Partials        722      722           
Flag Coverage Δ Complexity Δ
unittests 79.94% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bfac8a...f423bbd. Read the comment docs.

@@ -28,7 +28,7 @@ Now diKTat was already added to the lists of [static analysis tools](https://git

| | | | |
| --- | --- | --- | --- |
|[DiKTat codestyle](info/guide/diktat-coding-convention.md)|[Supported Rules](info/available-rules.md) | [Examples of Usage](https://github.com/akuleshov7/diktat-examples) | [Online Demo](https://ktlint-demo.herokuapp.com) |
|[DiKTat codestyle](info/guide/diktat-coding-convention.md)|[Supported Rules](info/available-rules.md) | [Examples of Usage](https://github.com/akuleshov7/diktat-examples) | [Online Demo](https://ktlint-demo.herokuapp.com) | [Whitepaper](wp/wp.pdf) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you decided to upload pdf to repo after all? Or we could add link to README in #655, as we planned, with link to gh releases.

Copy link
Member Author

@orchestr7 orchestr7 Jan 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, will after all we will need to add pdf

@@ -107,6 +108,8 @@ I [Preface](#c0)
* [6.4.2 Objects should be used for Stateless Interfaces](#r6.4.2)


# Huawei Coding Style Guide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not diktat?

@@ -1,3 +1,4 @@
# Diktat Coding Style Guide, v.0.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will we track these versions?

Copy link
Member Author

@orchestr7 orchestr7 Jan 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think that it is enough to have the version here, I do not like to put it into separate file later

### What's done:
Regenerated the codestyle
@orchestr7 orchestr7 merged commit cea7a7a into master Jan 13, 2021
@petertrr petertrr deleted the feature/code-style branch January 13, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants