Minor infrastructure improvements #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Fixed kotlin compiler warnings * Updated version in build.gradle.kts for diktat-gradle-plugin * Added update of info/buildSrc/gradle.properties version during release workflow * Run gradle functional tests in parallel
### What's done: * One-phase build in build_and_test.yml instead of two
Codecov Report
@@ Coverage Diff @@
## master #700 +/- ##
=========================================
Coverage 79.94% 79.94%
Complexity 1839 1839
=========================================
Files 87 87
Lines 4801 4801
Branches 1549 1549
=========================================
Hits 3838 3838
Misses 241 241
Partials 722 722
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
aktsay6
reviewed
Jan 13, 2021
aktsay6
reviewed
Jan 13, 2021
Comment on lines
+187
to
188
| val firstUsage = usages.minByOrNull { it.node.getLineNumber() }!! | ||
| val firstUsageScope = firstUsage.getParentOfType<KtBlockExpression>(true) |
There was a problem hiding this comment.
Isn't it gonna cause NPE if it returns null?
There was a problem hiding this comment.
min returns nullable too, they've just changed function names. We already had !! there, because we should always be able to sort by line number
Co-authored-by: Alexander Tsay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: