Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Years in copyright examples updated to 2021 #687

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Jan 6, 2021

What's done:

  • Years updated

Fixme

  • there are some incorrect fixing cases:
    • Additional blank line is inserted after rearranging comments
    • Sometimes, when year is still not changed, there is an NPE somewhere in year checking logic.
  • Overall, it seems there are some cases that need to be fixed and covered with tests in year checking logic.

### What's done:
* Years updated
### What's done:
* Code style
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #687 (364213f) into master (62c5a01) will decrease coverage by 0.00%.
The diff coverage is 81.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #687      +/-   ##
============================================
- Coverage     79.94%   79.94%   -0.01%     
- Complexity     1835     1839       +4     
============================================
  Files            87       87              
  Lines          4778     4801      +23     
  Branches       1544     1549       +5     
============================================
+ Hits           3820     3838      +18     
- Misses          239      241       +2     
- Partials        719      722       +3     
Flag Coverage Δ Complexity Δ
unittests 79.94% <81.57%> (-0.01%) 0.00 <5.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt 91.22% <80.00%> (-2.53%) 17.00 <2.00> (+2.00) ⬇️
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 93.06% <81.48%> (-4.64%) 11.00 <3.00> (+2.00) ⬇️
...n/org/cqfn/diktat/plugin/gradle/DiktatExtension.kt 100.00% <100.00%> (ø) 6.00 <0.00> (ø)
...diktat/ruleset/rules/comments/HeaderCommentRule.kt 86.45% <0.00%> (+2.08%) 42.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c852602...364213f. Read the comment docs.

Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit f38ce8b into master Jan 11, 2021
@petertrr petertrr deleted the hotfix/tests-2021 branch January 11, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants