Support setting config file via system property #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Added support in DiktatRuleSetProvider * Added support in diktat-gradle-plugin * Added example with gradle multimodule project * Added new functional test
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
============================================
- Coverage 79.94% 79.90% -0.05%
- Complexity 1835 1839 +4
============================================
Files 87 87
Lines 4778 4801 +23
Branches 1544 1549 +5
============================================
+ Hits 3820 3836 +16
- Misses 239 241 +2
- Partials 719 724 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Updated example * Code style
### What's done: * Code style
aktsay6
requested changes
Dec 31, 2020
...onalTest/kotlin/org/cqfn/diktat/plugin/gradle/DiktatGradlePluginMultimoduleFunctionalTest.kt
Outdated
Show resolved
Hide resolved
### What's done: * Refactoring
### What's done: * Refactoring
aktsay6
reviewed
Dec 31, 2020
Comment on lines
+165
to
166
| val closestMatch = Warnings.names.minByOrNull { Levenshtein.distance(it, config.name) } | ||
| "Warning name <${config.name}> in configuration file is invalid, did you mean <$closestMatch>?" |
There was a problem hiding this comment.
Does it happen in case if config is empty? If so do we need this warning message?
There was a problem hiding this comment.
Config can't be empty, at the very least we will use config included in the jar.
There was a problem hiding this comment.
Oh you used minByOrNull because minBy is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #672