Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule for complex expression #680

Merged
merged 14 commits into from
Jan 15, 2021
Merged

New rule for complex expression #680

merged 14 commits into from
Jan 15, 2021

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Dec 29, 2020

What's done:

Created new rule

Which rule and warnings did you add?

This pull request closes

Actions checklist

  • Implemented Rule, added Warnings
  • Added tests on checks
  • Updated diktat-analysis.yml
  • Updated available-rules.md

closes #676
closes #241

### What's done:
Created new rule
…ition

# Conflicts:
#	info/available-rules.md
@kentr0w kentr0w added the enhancement New feature or request label Dec 29, 2020
### What's done:
Fixed documentation
### What's done:
Fixed documentation
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #680 (d425513) into master (d34ed1c) will increase coverage by 0.07%.
The diff coverage is 78.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #680      +/-   ##
============================================
+ Coverage     80.00%   80.08%   +0.07%     
- Complexity     1864     1871       +7     
============================================
  Files            88       88              
  Lines          4852     4870      +18     
  Branches       1560     1565       +5     
============================================
+ Hits           3882     3900      +18     
+ Misses          241      238       -3     
- Partials        729      732       +3     
Flag Coverage Δ Complexity Δ
unittests 80.08% <78.12%> (+0.07%) 0.00 <17.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...at-rules/src/main/kotlin/generated/WarningNames.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../org/cqfn/diktat/ruleset/rules/NullableTypeRule.kt 80.26% <50.00%> (-0.56%) 39.00 <7.00> (ø)
...cqfn/diktat/ruleset/rules/AnnotationNewLineRule.kt 87.50% <66.66%> (+1.13%) 14.00 <0.00> (ø)
...lin/org/cqfn/diktat/ruleset/rules/SmartCastRule.kt 64.46% <66.66%> (+0.29%) 36.00 <0.00> (ø)
...rg/cqfn/diktat/ruleset/rules/files/NewlinesRule.kt 81.70% <85.71%> (+1.34%) 129.00 <10.00> (+7.00)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 97.69% <100.00%> (+0.01%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d34ed1c...d425513. Read the comment docs.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check snapshot diktat check, there are a lot of new error there.

info/available-rules.md Outdated Show resolved Hide resolved
info/guide/guide-chapter-3.md Outdated Show resolved Hide resolved
### What's done:
   Fixed after review
…ition

# Conflicts:
#	diktat-analysis.yml
#	diktat-rules/src/main/resources/diktat-analysis-huawei.yml
#	diktat-rules/src/main/resources/diktat-analysis.yml
### What's done:
   Fixed after merged
### What's done:
   Fixed after fixed
### What's done:
   Fixed according our code-style
### What's done:
   Fixed after review
### What's done:
   Fixed after review
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@aktsay6 aktsay6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kentr0w kentr0w merged commit 0b7cf0a into master Jan 15, 2021
@kentr0w kentr0w deleted the feature/dqe-in-condition branch January 15, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants