-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New rule for complex expression #680
Conversation
### What's done: Created new rule
…ition # Conflicts: # info/available-rules.md
### What's done: Fixed documentation
### What's done: Fixed documentation
…KTat into feature/dqe-in-condition
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
============================================
+ Coverage 80.00% 80.08% +0.07%
- Complexity 1864 1871 +7
============================================
Files 88 88
Lines 4852 4870 +18
Branches 1560 1565 +5
============================================
+ Hits 3882 3900 +18
+ Misses 241 238 -3
- Partials 729 732 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check snapshot diktat check, there are a lot of new error there.
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/files/NewlinesRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/files/NewlinesRule.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed after review
…ition # Conflicts: # diktat-analysis.yml # diktat-rules/src/main/resources/diktat-analysis-huawei.yml # diktat-rules/src/main/resources/diktat-analysis.yml
### What's done: Fixed after merged
### What's done: Fixed after fixed
### What's done: Fixed according our code-style
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/AnnotationNewLineRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/files/NewlinesRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/files/NewlinesRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/files/NewlinesRule.kt
Show resolved
Hide resolved
### What's done: Fixed after review
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/files/NewlinesRule.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed after review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What's done:
Created new rule
Which rule and warnings did you add?
This pull request closes
Actions checklist
closes #676
closes #241