Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GITHUB_ENV file instead of set-env command #534

Merged
merged 7 commits into from
Nov 17, 2020
Merged

Use GITHUB_ENV file instead of set-env command #534

merged 7 commits into from
Nov 17, 2020

Conversation

petertrr
Copy link
Member

What's done:

  • Updated diktat_snapshot.yml
  • Updated release.yml

This pull request closes #533

@petertrr
Use GITHUB_ENV file instead of set-env command
dc08769 
### What's done:
* Updated diktat_snapshot.yml
* Updated release.yml
@petertrr
Use GITHUB_ENV file instead of set-env command
7c0540c 
### What's done:
* Updated diktat_snapshot.yml
@codecov
Copy link

codecov bot commented Nov 17, 2020 •
edited
Loading

Codecov Report

Merging #534 (2dcf2e3) into master (fe2ad6f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #534   +/-   ##
=========================================
  Coverage     81.88%   81.88%           
  Complexity     1635     1635           
=========================================
  Files            78       78           
  Lines          4123     4123           
  Branches       1302     1302           
=========================================
  Hits           3376     3376           
  Misses          219      219           
  Partials        528      528
Flag Coverage Δ Complexity Δ
unittests 81.88% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe2ad6f...2dcf2e3. Read the comment docs.

@petertrr
Use GITHUB_ENV file instead of set-env command
2b6d672 
### What's done:
* Updated diktat_snapshot.yml
@petertrr
Use GITHUB_ENV file instead of set-env command
aea1893 
### What's done:
* Updated diktat_snapshot.yml
@petertrr
Use GITHUB_ENV file instead of set-env command
9c9d803 
### What's done:
* Updated diktat_snapshot.yml
@petertrr
Use GITHUB_ENV file instead of set-env command
dd8ae9d 
### What's done:
* Updated release.yml
@petertrr
Use GITHUB_ENV file instead of set-env command
2dcf2e3 
### What's done:
* Build only maven plugin in diktat_snapshot.yml
aktsay6
aktsay6 approved these changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@aktsay6 aktsay6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kentr0w
kentr0w approved these changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@kentr0w kentr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit 516347a into master Nov 17, 2020
@petertrr petertrr deleted the infra/github-env-files branch November 17, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aktsay6 aktsay6 aktsay6 approved these changes

@kentr0w kentr0w kentr0w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GH Actions: The set-env command is disabled. Please upgrade to using Environment Files
3 participants
@petertrr @kentr0w @aktsay6